StefanRRichter commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492164999 @1u0 thanks for the review. I think about renaming to sender/receiver, it might really better fit in the context. About shutdown, yes it is required, yes it is optimized and I purposefully did not put it to the writer interface because this method should not be visible to all writers, only the object owner (here the stream task) should be allowed to invoke this method, that is also why it can be "out of style" with the client code interfaces. Also I see no need for generifying the mailbox without a purpose. It is clearly scoped to runnables, and we avoid bloated code and casting. So what excatly would be the benefits?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
