kezhuw commented on issue #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#issuecomment-492331773 @StefanRRichter After read through https://docs.google.com/document/d/1eDpsUKv2FqwZiS1Pm6gYO5eFHScBHfULKmH1-ZEWB4g, I have some doubts about this feature which may relate to your discussion with @1u0 about message abstraction, I use word "letter" in following description to avoid conflicting with @1u0's point: * Will `StreamElement` handling, checkpoint handling be represented as letters in mailbox ? * Is there any cases that sender of letter do not know how to handle that letter, eg. do not know how to wrap it as `Runnable` ? If it is true to second question, I think it is the responsibility of mailbox, which has more knowledges than senders, to wrap not runnable letters as runnable letters if we don't want casting in processing of letters. Even in this case, I think overloading methods is a more appropriate approach than introducing generic message type as the latter is intrusive to type signature and may incur to unnecessary wrapper classes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
