xuefuz commented on a change in pull request #8434: [FLINK-12234][hive] Support
view related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8434#discussion_r283925761
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -169,8 +181,18 @@ protected Table createHiveTable(ObjectPath tablePath,
CatalogBaseTable table) {
sd.setCols(allColumns);
hiveTable.setPartitionKeys(new ArrayList<>());
}
+ } else if (table instanceof CatalogView) {
Review comment:
should we check against HiveCatalogView instead, as we are casting table to
it right after this line? Same applies to the check in the if condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
