sunjincheng121 commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284100035
########## File path: flink-python/pyflink/table/tests/test_table_completeness.py ########## @@ -0,0 +1,62 @@ +# ############################################################################### +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +from pyflink.testing.test_case_utils import PythonAPICompletenessTestCase +from pyflink.table import Table + + +class TableAPICompletenessTests(PythonAPICompletenessTestCase): + """ + Tests whether the Python :class:`Table` is consistent with + Java `org.apache.flink.table.api.Table`. + """ + + @classmethod + def python_class(cls): + return Table + + @classmethod + def java_class(cls): + return "org.apache.flink.table.api.Table" + + @classmethod + def excluded_methods(cls): + # row-based operators should be supported when UDFs supported in python. + return {'map', 'flatMap', 'flatAggregate', 'aggregate'} + + @classmethod + def java_method_name(cls, python_method_name): + """ + Due to 'as' is python keyword, so we use 'alias' + in Python API corresponding 'as' in Java API. + + :param python_method_name: + :return: + """ + return {'alias': 'as'}.get(python_method_name, python_method_name) + + +if __name__ == '__main__': + import unittest + + try: + import xmlrunner + testRunner = xmlrunner.XMLTestRunner(output='target/test-reports') + except ImportError: + testRunner = None + unittest.main(testRunner=testRunner, verbosity=2) Review comment: Already there :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
