zentol commented on a change in pull request #8413: [FLINK-12488][metrics] Pass
Status group to NetworkEnvironment
URL: https://github.com/apache/flink/pull/8413#discussion_r284131551
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -358,15 +360,15 @@ public static TaskExecutor startTaskManager(
remoteAddress,
localCommunicationOnly);
- TaskManagerMetricGroup taskManagerMetricGroup =
MetricUtils.instantiateTaskManagerMetricGroup(
+ Tuple2<TaskManagerMetricGroup, MetricGroup>
taskManagerMetricGroup = MetricUtils.instantiateTaskManagerMetricGroup(
Review comment:
This may be something we have to live with. The `MetricUtils` exists so that
JM/TM are roughly in sync with each other in what metrics they expose and how
the scope works.
Moving the status group initialization of the TM out of here makes this a
lot less obvious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
