twalthr commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r284151124
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/TimestampType.java
##########
@@ -152,12 +152,14 @@ public boolean equals(Object o) {
if (!super.equals(o)) {
return false;
}
+
TimestampType that = (TimestampType) o;
- return precision == that.precision;
+
+ return precision == that.precision && kind == that.kind;
Review comment:
Yes, we don't want to have special path and checks for time attributes
throughout the stack. If we want to check, we can use `getKind()` but the type
fully behaves like a timestamp otherwise. Also, the serialized string
representation is always just timestamp, so serialization and deserialization
leads to objects that are `equal`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
