zentol commented on a change in pull request #8430: [FLINK-12068] [runtime]
Backtrack failover regions if intermediate results are unavailable
URL: https://github.com/apache/flink/pull/8430#discussion_r284204343
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionStrategyTest.java
##########
@@ -30,37 +38,245 @@
public class RestartPipelinedRegionStrategyTest extends TestLogger {
Review comment:
What I'm missing here are a few _minimal_ tests for the key backtracking
behaviors, ideally with similar topologies to reduce cognitive load.
For example,
```
v1 |-\
-> v3
v2 |-/
v1/v2 fails -> v1&v3 is restarted, v2 optionally depending on partition
state
v3 fails, v3 is restarted, v1/v2 optionally dependending on partition state
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
