bowenli86 opened a new pull request #8457: [FLINK-12511][table][hive] make variable 'comment' in all catalog metadata classes final URL: https://github.com/apache/flink/pull/8457 ## What is the purpose of the change Because of historical reasons, currently the variable "comment" in all catalog metadata classes are not final yet, it has a default value and can be overwritten in constructor. It creates problems like overloaded constructors are built in a weird, if not wrong, way. (See code below). This PR removes the default value of "comment" and make it final that can only be assigned value upon construction, and ends the not-so-well-designed overloaded constructors for catalog metadata classes. ## Brief change log - made 'comment' in catalog metadata classes and removed its default value - rebuilt constructors for catalog metadata classes ## Verifying this change This change is already covered by existing tests, such as *CatalogTestBase*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
