bowenli86 commented on a change in pull request #8458:
[FLINK-12452][table][hive] alterTable() should ensure existing base table and
the new one are of the same type
URL: https://github.com/apache/flink/pull/8458#discussion_r284489117
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogBase.java
##########
@@ -318,13 +320,44 @@ public void alterTable(ObjectPath tablePath,
CatalogBaseTable newCatalogTable, b
throw new
TableNotExistException(catalogName, tablePath);
}
} else {
Review comment:
agree. Shall we do it separately since it's orthogonal to what this PR is
for? I will refactor that in a [hotfix] PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
