dawidwys commented on a change in pull request #8453:
[FLINK-12254][table-common] Preparation for using the new type system
URL: https://github.com/apache/flink/pull/8453#discussion_r284569495
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/VarCharType.java
##########
@@ -86,6 +89,9 @@ public LogicalType copy(boolean isNullable) {
@Override
public String asSerializableString() {
+ if (length == MAX_LENGTH) {
Review comment:
Could we have that only in the `summaryString`? Personally I'd prefer to
serialize only the actual types and not the shortcuts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
