pnowojski commented on a change in pull request #8442: [FLINK-12483] Support
(legacy) SourceFunction as special case in the mailbox model for stream tasks
URL: https://github.com/apache/flink/pull/8442#discussion_r284571980
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -98,12 +100,44 @@ protected void cleanup() {
}
@Override
- protected void run() throws Exception {
- headOperator.run(getCheckpointLock(),
getStreamStatusMaintainer());
+ protected void performDefaultAction(ActionContext context) throws
Exception {
+ // Against the usual contract of this method, this
implementation is not step-wise but blocking instead for
Review comment:
Wouldn't it be better to not hijack the execution from mailbox here? It's
kind of fishy this way, when one task behaves in a completely different way.
Maybe it would be better to run the mailbox loop in `StreamTask` always and
this `performDefaultAction` would just spawn a source thread, without joining
on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
