aljoscha commented on a change in pull request #8459: [FLINK-12476] [State TTL]
Consider setting a default background cleanup strategy in StateTtlConfig
URL: https://github.com/apache/flink/pull/8459#discussion_r284606407
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -327,6 +329,14 @@ public Builder cleanupInRocksdbCompactFilter(long
queryTimeAfterNumEntries) {
return this;
}
+ /**
+ * Cleanup expired state by activating both strategies.
Depending on actually used backend, the corresponding cleanup will kick in.
+ */
+ @Nonnull
+ public Builder cleanupInBackground() {
+ return cleanupIncrementally(10,
true).cleanupInRocksdbCompactFilter(1000L);
Review comment:
I don't think the setting should delegate to the specific options. This will
mean that this code will have to be adapted in the future if other backends or
other cleanup strategies are added.
The state backends should notice that "cleanup in background" is enabled and
then react accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
