azagrebin opened a new pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463 ## What is the purpose of the change Task.inputGatesById indexes SingleInputGates by id. The end user of this indexing is NetworkEnviroment for two cases: - SingleInputGate triggers producer partition readiness check and then the successful result of check is dispatched back to this SingleInputGate by id. We can just add an additional argument to TaskActions.triggerPartitionProducerStateCheck. The argument is an immediate callback to that SingleInputGate. Then inputGatesById is not needed for dispatching. - TaskExecutor.updatePartitions uses inputGatesById to dispatch PartitionInfo update to the right SingleInputGate. If inputGatesById is moved to NetworkEnviroment, which should be a better place for gate management, and add NetworkEnviroment.updatePartitionInfo then TaskExecutor.updatePartitions could directly call NetworkEnviroment.updatePartitionInfo. ## Brief change log - Change TaskActions.triggerPartitionProducerStateCheck to use callback instead of inputGatesById - add NetworkEnviroment.updatePartitionInfo - use NetworkEnviroment.updatePartitionInfo in TaskExecutor.updatePartitions instead of Task.inputGatesById - move Move Task.inputGatesById to NetworkEnvironment - add SingleInputGate.close callback to remove gate from NetworkEnvironment.inputGatesById ## Verifying this change the change is a refactoring ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
