azagrebin commented on a change in pull request #8428: [FLINK-12497][network]
Refactor the start method of ConnectionManager
URL: https://github.com/apache/flink/pull/8428#discussion_r284632408
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConnectionManager.java
##########
@@ -35,24 +37,27 @@
private final PartitionRequestClientFactory
partitionRequestClientFactory;
- private final boolean isCreditBased;
+ private final NettyProtocol nettyProtocol;
+
+ public NettyConnectionManager(
+ ResultPartitionProvider partitionProvider,
+ TaskEventPublisher taskEventPublisher,
+ NettyConfig nettyConfig,
+ boolean isCreditBased) {
- public NettyConnectionManager(NettyConfig nettyConfig, boolean
isCreditBased) {
this.server = new NettyServer(nettyConfig);
this.client = new NettyClient(nettyConfig);
this.bufferPool = new
NettyBufferPool(nettyConfig.getNumberOfArenas());
this.partitionRequestClientFactory = new
PartitionRequestClientFactory(client);
- this.isCreditBased = isCreditBased;
+ this.nettyProtocol = new
NettyProtocol(checkNotNull(partitionProvider),
checkNotNull(taskEventPublisher), isCreditBased);
Review comment:
could be new line after `new NettyProtocol(` to avoid long lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
