lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive]
Support partition related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8449#discussion_r284967779
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -412,31 +418,22 @@ public void createPartition(ObjectPath tablePath,
CatalogPartitionSpec partition
checkNotNull(partitionSpec);
checkNotNull(partition);
- if (!tableExists(tablePath)) {
Review comment:
It's intended to reduce code duplication. And makes things easier if we want
to, say, change exception message in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
