WeiZhong94 commented on a change in pull request #8472: [FLINK-12327][python]
Adds support to submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#discussion_r285063089
##########
File path: flink-dist/src/main/flink-bin/bin/flink
##########
@@ -51,5 +62,16 @@ log_setting=(-Dlog.file="$log"
-Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4
export FLINK_ROOT_DIR
export FLINK_CONF_DIR
+# Get the path of ${FLINK_ROOT_DIR}/opt/flink-table*.jar.
+TABLE_JAR_PATH=`echo "$FLINK_ROOT_DIR"/opt/flink-table*.jar`
+if [[ $(isPython "$@") -eq 0 ]]; then
+ TABLE_JAR_PATH=`echo "$FLINK_ROOT_DIR"/opt/flink-table*.jar`
+ CLASSPATH=`manglePathList
"$TABLE_JAR_PATH:$CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS"`
+ # use the -C option to add the flink-table relevant jar to the
classpath.
+ arg="-classpath $CLASSPATH org.apache.flink.client.cli.CliFrontend $@
-C file:///$TABLE_JAR_PATH"
Review comment:
As far as I know, the URL in -C option needs to be accessible by all nodes
on the cluster. If it is just a local file path, we must make sure that it is
also accessible in other nodes' machines. Perhaps this design only works on
local mode?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
