azagrebin commented on a change in pull request #8445:
[FLINK-12127][network,config] Move network related options form
TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions
URL: https://github.com/apache/flink/pull/8445#discussion_r285104973
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java
##########
@@ -38,53 +36,6 @@
private static final Logger LOG =
LoggerFactory.getLogger(NettyConfig.class);
- // - Config keys
----------------------------------------------------------
-
- public static final ConfigOption<Integer> NUM_ARENAS = ConfigOptions
Review comment:
`NetworkEnvironment` relies on `NetworkEnvironmentConfiguration` which is
basically a Java parsed version of `NetworkEnvironmentOptions`. `NettyConfig`
is part of `NetworkEnvironmentConfiguration`, also parsed and intended for
`NetworkEnvironment`. It is all about netty used for shuffling. We also
consider netty shuffle implementation to be the default one as it is basically
now. I am not sure about splitting its config. Other shuffle services might
reuse these options, might not. Their additional options will be separate
anyways, either own class or even outside of Flink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
