tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the PartitionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r285107062
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManagerTest.java ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition; + +import org.junit.Test; + +import java.io.IOException; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.fail; + +/** + * Tests for {@link ResultPartitionManager}. + */ +public class ResultPartitionManagerTest { + + /** + * Tests that {@link ResultPartitionManager#createSubpartitionView(ResultPartitionID, int, BufferAvailabilityListener)} + * would throw {@link PartitionNotFoundException} if this partition was not registered before. + */ + @Test + public void testThrowPartitionNotFoundException() throws Exception { + final ResultPartitionManager partitionManager = new ResultPartitionManager(); + final ResultPartition partition = PartitionTestUtils.createPartition(); + try { + partitionManager.createSubpartitionView(partition.getPartitionId(), 0, new NoOpBufferAvailablityListener()); + + fail("Should throw PartitionNotFoundException for unregistered partition."); + } catch (PartitionNotFoundException notFound) { + assertEquals(partition.getPartitionId(), notFound.getPartitionId()); + } + } + + /** + * Tests {@link ResultPartitionManager#createSubpartitionView(ResultPartitionID, int, BufferAvailabilityListener)} + * successful if this partition was already registered before. + */ + @Test + public void testCreateViewForRegisteredPartition() { + final ResultPartitionManager partitionManager = new ResultPartitionManager(); + final ResultPartition partition = PartitionTestUtils.createPartition(); + try { + partitionManager.registerResultPartition(partition); + partitionManager.createSubpartitionView(partition.getPartitionId(), 0, new NoOpBufferAvailablityListener()); + } catch (IOException e) { Review comment: No need to catch the exception. Let it simply bubble up. This is enough to fail the test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
