zhijiangW commented on a change in pull request #8445:
[FLINK-12127][network,config] Move network related options form
TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions
URL: https://github.com/apache/flink/pull/8445#discussion_r285169365
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java
##########
@@ -38,53 +36,6 @@
private static final Logger LOG =
LoggerFactory.getLogger(NettyConfig.class);
- // - Config keys
----------------------------------------------------------
-
- public static final ConfigOption<Integer> NUM_ARENAS = ConfigOptions
Review comment:
Thanks for sharing the experience in `ResourceManagerOptions` @zentol !
The `NettyConfig` is actually used in current `NetworkEnvironment` which
should start `NettyClient` and `NettyServer` based on `NettyConfig`. So all the
options in `NetworkEnvironmentOptions` are used by `NetworkEnvironment` atm.
But TBH I am also not sure the other shuffle services would reuse it or not,
and it might rely on which kind of shuffle service we want to implement future.
So the current `NetworkEnvironmentOptions` might be a special one for the
default implementation or a general one for some implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
