hxbks2ks commented on a change in pull request #8472: [FLINK-12327][python] 
Adds support to submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#discussion_r285173257
 
 

 ##########
 File path: flink-dist/src/main/flink-bin/bin/flink
 ##########
 @@ -51,5 +62,16 @@ log_setting=(-Dlog.file="$log" 
-Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4
 export FLINK_ROOT_DIR
 export FLINK_CONF_DIR
 
+# Get the path of ${FLINK_ROOT_DIR}/opt/flink-table*.jar.
+TABLE_JAR_PATH=`echo "$FLINK_ROOT_DIR"/opt/flink-table*.jar`
+if [[ $(isPython "$@") -eq 0 ]]; then
+       TABLE_JAR_PATH=`echo "$FLINK_ROOT_DIR"/opt/flink-table*.jar`
+       CLASSPATH=`manglePathList 
"$TABLE_JAR_PATH:$CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS"`
+       # use the -C option to add the flink-table relevant jar to the 
classpath.
+       arg="-classpath $CLASSPATH org.apache.flink.client.cli.CliFrontend $@ 
-C file:///$TABLE_JAR_PATH"
 
 Review comment:
   Thank you for finding this error.Because flink currently don't support 
submitting a list of jars.I choose to put flink-table-*.jar in jarFilePath as a 
tmpral way.If flink support submitting jars in the future,the relevant 
realization will be corrected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to