wuchong commented on a change in pull request #8462:
[FLINK-12496][table-planner-blink] Support translation from
StreamExecGroupWindowAggregate to StreamTransformation.
URL: https://github.com/apache/flink/pull/8462#discussion_r285169795
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
##########
@@ -190,11 +190,11 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
buildRelDataType(
tableSchema.getFieldNames.toSeq,
tableSchema.getFieldTypes map {
- case TimeIndicatorTypeInfo.PROCTIME_INDICATOR
- if isStreaming.isDefined && !isStreaming.get =>
+ case tp: TimeIndicatorTypeInfo
+ if !tp.isEventTime && isStreaming.isDefined && !isStreaming.get =>
InternalTypes.TIMESTAMP
- case TimeIndicatorTypeInfo.ROWTIME_INDICATOR
- if isStreaming.isDefined && !isStreaming.get =>
+ case tp: TimeIndicatorTypeInfo
+ if tp.isEventTime && isStreaming.isDefined && !isStreaming.get =>
Review comment:
Combine the above two case in to `case tp: TimeIndicatorTypeInfo if
isStreaming.isDefined && !isStreaming.get` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
