HuangZhenQiu commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r285362730
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
##########
@@ -55,6 +55,18 @@
" default, the port of the JobManager, because the same
ActorSystem is used." +
" Its not possible to use this configuration key to
define port ranges.");
+ /**
+ * Defines the maximum number of workers (YARN / Mesos) failure can
happen in a minute.
Review comment:
From our production experience, it would be better to let the job failure
immediately to make engineer to involve into the issue. The failure rate here
is to just distinguish whether it is a transient failure or real issue caused
by external systems such as hdfs. Thus, I am not sure it is needed for wait for
failure rate falls below the maximum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
