Github user tammymendt commented on the pull request:
https://github.com/apache/flink/pull/605#issuecomment-138883419
The test I wrote checks if the final accumulator result is the one that is
expected. If I understand correctly, now accumulator values are sent
periodically before a task finishes. Do I need to write an additional test to
make sure that accumulator results before task end are also as expected? If not
I would say it is ok to merge. Have you written extra tests for other
accumulators like IntCounter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
