xuefuz opened a new pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480 …alog <!-- *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> ## What is the purpose of the change This PR is to combine GenericHiveMetastoreCatalog and HiveCatalog into one single class. The reasons are: 1. they both talk to Hive metastore to store/retrieve metadata stored in Hive and the implementation is very similar. 2. User needs two catalogs in order to store both generic metadata and Hive metadata. If the two points to the same Hive metastore instance, each will see the same list of meta objects (such as tables) but may not understand if the objects are not created by itself. This creates a lot of confusion to the users. If the two catalog doesn't share Hive metastore, then it's a deployment overhead. Using a single catalog avoids both. To differentiate the two types of meta objects in a single catalog, Generic meta objects will have a property named "is_generic". ## Brief change log *(for example:)* - Combined and merged code in GenericHiveMetastoreCatalog and HiveCatalogBase into HiveCatalog - Removed GenericHiveMetastoreCatalog and HiveCatalogBase class - Added abstract classes for tables/views/functions/partitions/databases for both type of meta objects - Adapted existing tests ## Verifying this change This change is already covered by existing tests, such as GenericInMemoryCatalogTest, GenericHiveMetastoreCatalogTest, and HiveCatalogTest. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes) - The serializers: (No) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (No) - The S3 file system connector: (No) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
