[
https://issues.apache.org/jira/browse/FLINK-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843630#comment-16843630
]
Jing Zhang commented on FLINK-12348:
------------------------------------
[~twalthr], do you prefer that PlannerConfig provides methods for setting
planner-related string-string pairs, however the underlying map stores in the
member of TableConfig?
And [~jark]'s concern also make sense, how about the following solution?
We provide two options for users to get/set planner configuration:
1. Directly read/write a member `org.apache.flink.configuration.Configuration`
in TableConfig based on a certain key. In the way, there is no difference to
set a planner-related configuration or API-related configuration. However,
users need know the exact key string.
2. Calls methods in PlannerConfig to read/write the configuration. In the way,
users must know that API-related configurations need to be configured via
TableConfig and planner-related configurations need to be configured via
PlannerConfig. However, users does not need to care the exact key string.
> Make TableConfig configurable from string-string map
> ----------------------------------------------------
>
> Key: FLINK-12348
> URL: https://issues.apache.org/jira/browse/FLINK-12348
> Project: Flink
> Issue Type: Task
> Components: Table SQL / API
> Reporter: Jing Zhang
> Assignee: Jing Zhang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since TableConfig already moved to API module in
> [FLINK-11067|https://issues.apache.org/jira/browse/FLINK-11067], TableConfig
> in blink-planner-module should not exist anymore. The issue aims to remove
> the TableConfig in blink-planner-module, use TableConfig in API module
> instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
