[
https://issues.apache.org/jira/browse/FLINK-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843725#comment-16843725
]
vinoyang commented on FLINK-6755:
---------------------------------
[~srichter] If we just think it's a new trigger strategy then we may not have
necessary to reset the timer because it's not periodic scheduling. IMO, we
should have another execution branch to support manual checkpoint. About
general side effects, it's still a problem like stop-with-savepoint scene.
Actually, I think the core internal {{triggerCheckpoint}} need to be
refactored. With more and more features are added, it would become more and
more complicated. There are more and more {{if/else}} branches, it would be
hard to maintain. If we want to implement this feature, I suggest introducing
an interface such as {{CheckpointTriggerStrategy}} to separate complex
implementations. WDYT?
> Allow triggering Checkpoints through command line client
> --------------------------------------------------------
>
> Key: FLINK-6755
> URL: https://issues.apache.org/jira/browse/FLINK-6755
> Project: Flink
> Issue Type: New Feature
> Components: Command Line Client, Runtime / Checkpointing
> Affects Versions: 1.3.0
> Reporter: Gyula Fora
> Assignee: vinoyang
> Priority: Major
>
> The command line client currently only allows triggering (and canceling with)
> Savepoints.
> While this is good if we want to fork or modify the pipelines in a
> non-checkpoint compatible way, now with incremental checkpoints this becomes
> wasteful for simple job restarts/pipeline updates.
> I suggest we add a new command:
> ./bin/flink checkpoint <jobID> [checkpointDirectory]
> and a new flag -c for the cancel command to indicate we want to trigger a
> checkpoint:
> ./bin/flink cancel -c [targetDirectory] <jobID>
> Otherwise this can work similar to the current savepoint taking logic, we
> could probably even piggyback on the current messages by adding boolean flag
> indicating whether it should be a savepoint or a checkpoint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
