HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python]
Adds support to submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#discussion_r285457290
##########
File path: flink-dist/src/main/flink-bin/bin/flink
##########
@@ -51,5 +62,16 @@ log_setting=(-Dlog.file="$log"
-Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4
export FLINK_ROOT_DIR
export FLINK_CONF_DIR
+# Get the path of ${FLINK_ROOT_DIR}/opt/flink-table*.jar.
+TABLE_JAR_PATH=`echo "$FLINK_ROOT_DIR"/opt/flink-table*.jar`
+if [[ $(isPython "$@") -eq 0 ]]; then
+ TABLE_JAR_PATH=`echo "$FLINK_ROOT_DIR"/opt/flink-table*.jar`
+ CLASSPATH=`manglePathList
"$TABLE_JAR_PATH:$CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS"`
+ # use the -C option to add the flink-table relevant jar to the
classpath.
+ arg="-classpath $CLASSPATH org.apache.flink.client.cli.CliFrontend $@
-C file:///$TABLE_JAR_PATH"
Review comment:
After considering that jarFile can only contain a jar file that uploaded, I
have put flink-jar in the method getAllLibraries of Packagedrogram.Because all
jars uploaded will be added in the libs, it looks like a better solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services