azagrebin commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r285555548
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateFairnessTest.java
##########
@@ -327,7 +327,8 @@ public FairnessVerifyingInputGate(
boolean isCreditBased) {
super(owningTaskName, jobId, consumedResultId,
ResultPartitionType.PIPELINED,
- consumedSubpartitionIndex,
numberOfInputChannels, taskActions, new SimpleCounter(), isCreditBased);
+ consumedSubpartitionIndex,
numberOfInputChannels, taskActions, new SimpleCounter(),
+ isCreditBased, () -> null);
Review comment:
I would prefer `throw new UnsupportedOperationException()`. There is no need
for `Optional` in production code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
