dianfu commented on a change in pull request #8472: [FLINK-12327][python] Adds
support to submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#discussion_r285559056
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -451,6 +476,31 @@ public ClassLoader getUserCodeClassLoader() {
if (jarFile != null) {
libs.add(jarFile);
}
+
+ if (isPython) {
Review comment:
We should not put `flink-table` to the class path by default for two reasons:
1) It's not necessary for Python API, as we may support other Python API
such as DataStream API in the future. `flink-table` is not necessary for these
kinds of Python API
2) It should be done by users manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
