dawidwys commented on a change in pull request #8497: [FLINK-12566][table]
Remove row interval type
URL: https://github.com/apache/flink/pull/8497#discussion_r286001971
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expressions/literals.scala
##########
@@ -60,7 +60,6 @@ case class Literal(value: Any, resultType:
TypeInformation[_]) extends LeafExpre
case [email protected] => value.toString + ".toTimestamp"
case [email protected]_MILLIS => value.toString + ".millis"
case [email protected]_MONTHS => value.toString + ".months"
- case [email protected]_ROWS => value.toString + ".rows"
Review comment:
How about we leave this suffix, and just replace the return type with
`LONG_TYPE_INFO`? This is part of the API as far as I understand. If we remove
that some of the user programs might fail.
It would also be inline with the scala dsl. You didn't remove the
`org.apache.flink.table.api.scala.ImplicitExpressionOperations#rows`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
