azagrebin commented on a change in pull request #8463: [FLINK-12530][network]
Move Task.inputGatesById to NetworkEnvironment
URL: https://github.com/apache/flink/pull/8463#discussion_r286010823
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
##########
@@ -542,6 +543,29 @@ public void testUpdateUnknownInputChannel() throws
Exception {
}
}
+ @Test
Review comment:
I think we can rely on ConcurrentHashMap provided in constructor (I changed
the approach a bit), then there is no need to test ConcurrentHashMap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
