sunjincheng121 edited a comment on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API URL: https://github.com/apache/flink/pull/8488#issuecomment-494621847 One more comment: Please improve the description of PR, It's better to tell the reviewer which part you have a process in a special way, such as: - the PR do not add the `schema()` method for `OldCsv` - explain more why you add the `test_descriptor_end_to_end` test. - Make the PR description as consist of PR changes as possible, such as: ``` In the Rowtime class, there are two APIs that define the watermark strategy. Do we need to keep both of them? ``` Just a suggestion and I know you already did a good job. :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
