liyafan82 edited a comment on issue #8278: [FLINK-12335][Table-runtime]Remove useless code in class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#issuecomment-494286726 > Thanks @liyafan82 for you code, maybe you can change the title to `remove useless code in SegmentsUtil`, I think the jdk/jvm will optimizer it, so maybe performance keep same. Thanks for your comments. I have made some investigations to analyze the assembly generated by JIT. It seems that JIT successfully removes BIT_BYTE_POSITION_MASK, so there can be no performance overhead. This PR only improves the code structure. 
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
