c4emmmm commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-494682592 > Thanks for contributing this PR, and great to see new machine learning effort arriving at Flink! > > We also need to create a licensing NOTICE file to declare bundled libs. According to my experience, the community prefers to have it at the first place in case we forget it which may delay the later release process. Please include that in this PR, or open a PR as immediate followup. You can take a look at https://cwiki.apache.org/confluence/display/FLINK/Licensing and use [flink-connector-hive's NOTICE file](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-hive/src/main/resources/META-INF/NOTICE) as an example @bowenli86 Thanks for your notice. According to the advice to replace gson with flink-shaded-jackson, I have refactored the code and changed the dependency. Since now flink-ml-api only depends on "flink-table-api-java" and "flink-shaded-jackson", I think we no longer need the NOTICE file. Please let me know if I'm mistaken.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
