zhijiangW commented on a change in pull request #8346: [FLINK-12405] [DataSet]
Introduce BLOCKING_PERSISTENT result partition type
URL: https://github.com/apache/flink/pull/8346#discussion_r286366466
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java
##########
@@ -49,13 +59,17 @@
/** Does this partition use a limited number of (network) buffers? */
private final boolean isBounded;
+ /** This partition will not be released after consuming if
'isPersistent' is true. */
+ private final boolean isPersistent;
Review comment:
I think we want to introduce a property to indicate this partition is global
across jobs. So `isPersistent` seems not reflect this behavior, because
`BLOCKING` type is also for persistent file from the semantics. Maybe called
`isGlobal`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
