sunjincheng121 commented on a change in pull request #8472:
[FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#discussion_r286397756
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java
##########
@@ -62,17 +65,63 @@
private final SavepointRestoreSettings savepointSettings;
+ // Flag indicating whether the job is a Python job.
+ private final boolean isPython;
+
protected ProgramOptions(CommandLine line) throws CliArgsException {
super(line);
String[] args = line.hasOption(ARGS_OPTION.getOpt()) ?
- line.getOptionValues(ARGS_OPTION.getOpt()) :
- line.getArgs();
+ line.getOptionValues(ARGS_OPTION.getOpt()) :
+ line.getArgs();
+
+ isPython = line.hasOption(PY_OPTION.getOpt()) |
line.hasOption(PYMODULE_OPTION.getOpt());
+ // If specified the option -py(--python)
+ if (line.hasOption(PY_OPTION.getOpt())) {
+ // Cannot use option -py and -pym simultaneously.
+ if (line.hasOption(PYMODULE_OPTION.getOpt())) {
+ throw new CliArgsException("Cannot use option
-py and -pym simultaneously.");
+ }
+ // The args format is : py ${python.py} [optional]pyfs
[optional]${py-files} [optional]other args.
+ // e.g. py wordcount.py
+ // e.g. py wordcount.py pyfs
file:///AAA.py,hdfs:///BBB.py --input in.txt --output out.txt
+ String[] newArgs;
+ int argIndex;
+ if (line.hasOption(PYFILES_OPTION.getOpt())) {
+ newArgs = new String[args.length + 4];
+ newArgs[2] = PYFILES_OPTION.getOpt();
+ newArgs[3] =
line.getOptionValue(PYFILES_OPTION.getOpt());
+ argIndex = 4;
+ } else {
+ newArgs = new String[args.length + 2];
+ argIndex = 2;
+ }
+ newArgs[0] = PY_OPTION.getOpt();
+ newArgs[1] = line.getOptionValue(PY_OPTION.getOpt());
+ System.arraycopy(args, 0, newArgs, argIndex,
args.length);
+ args = newArgs;
+ }
+
+ // If specified the option -pym(--pyModule)
+ if (line.hasOption(PYMODULE_OPTION.getOpt())) {
+ // If you specify the option -pym, you should specify
the option --pyFiles simultaneously.
+ if (!line.hasOption(PYFILES_OPTION.getOpt())) {
+ throw new CliArgsException("-pym must be used
in conjunction with `--pyFiles`");
+ }
+ // The args format is pym ${py-module} pyfs ${py-files}
[optional]other args.
+ // e.g. pym aaa.fun AAA.py, BBB.py
Review comment:
`pym aaa.fun` -> `-pym aaa.fun`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
