twalthr commented on a change in pull request #8493: [FLINK-12562][table]
Improve code in ExpandColumnFunctionsRule
URL: https://github.com/apache/flink/pull/8493#discussion_r286539834
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/expressions/rules/ExpandColumnFunctionsRule.java
##########
@@ -193,7 +190,7 @@ public
ColumnsExpressionExpander(List<UnresolvedReferenceExpression> inputFieldR
@Override
protected List<UnresolvedReferenceExpression>
defaultMethod(Expression expression) {
- throw new TableException(
+ throw new ValidationException(
String.format("The parameters of %s() or %s()
only accept column name or column " +
Review comment:
One additional location that looks inconsistent regarding exceptions. Is the
`Preconditions.checkArgument`. Usually this method is for checking if we (the
Flink developers) did everything correct however this check is also validating
user input, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
