zhijiangW commented on a change in pull request #8509: [FLINK-12458][network]
Introduce PartitionConnectionException for unreachable producer
URL: https://github.com/apache/flink/pull/8509#discussion_r286552249
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -159,11 +159,15 @@ void assignExclusiveSegments(List<MemorySegment>
segments) {
*/
@VisibleForTesting
@Override
- public void requestSubpartition(int subpartitionIndex) throws
IOException, InterruptedException {
+ public void requestSubpartition(int subpartitionIndex) throws
IOException {
if (partitionRequestClient == null) {
// Create a client and request the partition
- partitionRequestClient = connectionManager
- .createPartitionRequestClient(connectionId);
+ try {
+ partitionRequestClient =
connectionManager.createPartitionRequestClient(connectionId);
+ } catch (Throwable t) {
Review comment:
Only the `InterruptedException` might be thrown during
`future.waitForChannel()`. If we only catch the `IOException`, then for other
cases we could keep the previous behavior to throw the raw exception directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
