ifndef-SleePy opened a new pull request #8524: [FLINK-12591][test] Fix unstable test case StatsDReporterTest URL: https://github.com/apache/flink/pull/8524 ## What is the purpose of the change * `StatsDReporterTest` is unstable, fix it ## Brief change log * The reason of unstable is that, there is a race condition of `DatagramSocketReceiver.waitUntilNumLines`. * We need to get the lock outside the loop since `Object.wait` might wake up without a notification. It might miss the notification when checking the loop condition caused by self wakeup. ## Verifying this change * This change is already covered by existing tests * I have verified it by looping executing `StatsDReporterTest.testStatsDMetersReportingOfNegativeValues` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
