zhuzhurk commented on a change in pull request #8498: [FLINK-12413] [runtime] 
Implement ExecutionFailureHandler
URL: https://github.com/apache/flink/pull/8498#discussion_r287250729
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailoverStrategy.java
 ##########
 @@ -34,4 +34,22 @@
         * @return set of IDs of vertices to restart
         */
        Set<ExecutionVertexID> getTasksNeedingRestart(ExecutionVertexID 
executionVertexId, Throwable cause);
+
+       // 
------------------------------------------------------------------------
+       //  factory
+       // 
------------------------------------------------------------------------
 
 Review comment:
   Sorry but I don't have that book.
   Let's just keep it as this marker usage is widely used in Flink.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to