azagrebin commented on issue #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#issuecomment-495525981 Thanks for the review @zhijiangW, I've addressed comments. I think `PartitionProducerStateChecker` and `PartitionProducerChecker` have different levels of abstraction. The state checker is used by Task to query the execution state of the producer from JM, basically their RPC interface. Then task makes further decisions based on it. Shuffle API (remote channel) is basically interested in only whether the partition producer is producing or not at the moment. I think, there is a bit coupling between Task decisions and netty implementation at the moment. We might later further rethink it and maybe move Task logic completely into netty implementation based on just the producer state.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
