tillrohrmann commented on a change in pull request #8537: [FLINK-12115][fs] Add
support for AzureFS
URL: https://github.com/apache/flink/pull/8537#discussion_r287400354
##########
File path: flink-filesystems/flink-azure-fs-hadoop/pom.xml
##########
@@ -119,17 +111,69 @@ under the License.
</includes>
</artifactSet>
<relocations>
+ <!-- relocate
the references to Hadoop to match the shaded Hadoop config -->
<relocation>
<pattern>org.apache.hadoop</pattern>
-
<shadedPattern>org.apache.flink.fs.shaded.hadoop.org.apache.hadoop</shadedPattern>
+
<shadedPattern>org.apache.flink.fs.shaded.hadoop3.org.apache.hadoop</shadedPattern>
</relocation>
- <!-- relocate
the azure-storage dependencies -->
+
+ <!-- shade
dependencies internally used by Hadoop and never exposed downstream -->
+ <relocation>
+
<pattern>org.apache.commons</pattern>
+
<shadedPattern>org.apache.flink.fs.shaded.hadoop3.org.apache.commons</shadedPattern>
+ </relocation>
+
+ <!-- relocate
the Azure dependencies -->
<relocation>
-
<pattern>com.microsoft.azure.storage</pattern>
-
<shadedPattern>org.apache.flink.fs.shaded.com.microsoft.azure.storage</shadedPattern>
+
<pattern>com.microsoft.azure</pattern>
+
<shadedPattern>org.apache.flink.fs.azure.shaded.com.microsoft.azure</shadedPattern>
+ </relocation>
+
+ <!-- shade
dependencies internally used by Azure and never exposed downstream -->
+ <relocation>
+
<pattern>org.apache.httpcomponents</pattern>
Review comment:
If the plugins are used then not. If people drop the jar into `lib` it would
still be beneficial. Therefore, I opted for this approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
