bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] 
Implement TableSink and OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#discussion_r287526502
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -239,13 +253,10 @@ under the License.
                        </exclusions>
                </dependency>
 
-               <!-- test dependencies -->
-
                <dependency>
                        <groupId>org.apache.hive</groupId>
                        <artifactId>hive-exec</artifactId>
                        <version>${hive.version}</version>
-                       <scope>test</scope>
 
 Review comment:
   can you open an immediate followup PR and add new libraries packaged in 
flink-connector-hive to license notice file? 
https://github.com/apache/flink/pull/8205 is a good example

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to