pnowojski commented on a change in pull request #8467: [FLINK-12535][network]
Make CheckpointBarrierHandler non-blocking
URL: https://github.com/apache/flink/pull/8467#discussion_r287720937
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -494,12 +486,12 @@ public void requestPartitions() throws IOException,
InterruptedException {
//
------------------------------------------------------------------------
@Override
- public Optional<BufferOrEvent> getNextBufferOrEvent() throws
IOException, InterruptedException {
+ public Optional<BufferOrEvent> getNext() throws IOException,
InterruptedException {
return getNextBufferOrEvent(true);
Review comment:
I think yes. Blocking method looks like it is only used in
`AbstractRecordReader` and/or in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
