pnowojski commented on a change in pull request #8495: [FLINK-12556][e2e] Extend some end-to-end tests to run with custom (input) File System implementation URL: https://github.com/apache/flink/pull/8495#discussion_r287802609
########## File path: flink-end-to-end-tests/flink-plugins-test/src/main/java/org/apache/flink/fs/dummy/DummyFileSystemFileStatus.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.fs.dummy; + +import org.apache.flink.core.fs.FileStatus; +import org.apache.flink.core.fs.Path; + +class DummyFileSystemFileStatus implements FileStatus { Review comment: Ok I get your point. In that case I would vote for one of the following: 1. `DummyFileSystem`, `DumyFileStatus`, `DummyDataInputStream` 2. `DummyFSFileSystem` `DumyFSFileStatus`, `DummyFSDataInputStream` (note `FS` which would also feet the code base better compared to `Fs` and note that all files should have the same prefix) 3. Rename it altogether, for example to `StaticContent` or `PredefinedContent` (`StaticContentFileSystem`, `StaticContentFileStatus`, `StaticContentDataInputStream`, ...) I think the 3rd would be the best, as it also describes in what way the file system is "dummy", not just the fact that it is "dummy". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
