zentol commented on a change in pull request #8545: [FLINK-12520] Support to
provide fully-qualified domain host name in TaskManagerMetricGroup
URL: https://github.com/apache/flink/pull/8545#discussion_r287806224
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskManagerLocation.java
##########
@@ -202,7 +214,11 @@ public static String getHostName(InetAddress inetAddress)
{
LOG.warn("No hostname could be resolved for the IP
address {}, using IP address as host name. "
+ "Local input split assignment (such as for
HDFS files) may be impacted.", inetAddress.getHostAddress());
} else {
- hostName = NetUtils.getHostnameFromFQDN(fqdnHostName);
+ if (useFullHostName) {
+ hostName = fqdnHostName;
Review comment:
this case should most certainly not be handled in this method. Have the
TaskManagerRunner call `getFqdnHostName` instead (after making it public).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
