azagrebin commented on a change in pull request #8459: [FLINK-12476] [State 
TTL] Consider setting a default background cleanup strategy in StateTtlConfig
URL: https://github.com/apache/flink/pull/8459#discussion_r287809610
 
 

 ##########
 File path: docs/dev/stream/state/state.md
 ##########
 @@ -483,11 +513,12 @@ val ttlConfig = StateTtlConfig
 </div>
 
 RocksDB compaction filter will query current timestamp, used to check 
expiration, from Flink every time 
-after processing certain number of state entries. This number is 1000 by 
default. 
+after processing certain number of state entries.
 You can optionally change it and pass a custom value to 
 
 Review comment:
   let's remove `optionally` and put `1000` into 
`cleanupInRocksdbCompactFilter(1000)` in java and scala examples as we are 
deprecating the parameterless version of `cleanupInRocksdbCompactFilter`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to