xuefuz commented on a change in pull request #8541: [FLINK-9172][sql-client]
Support catalogs in SQL-Client yaml config file
URL: https://github.com/apache/flink/pull/8541#discussion_r287912450
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -227,6 +241,12 @@ private static ClusterSpecification
createClusterSpecification(CustomCommandLine
}
}
+ private Catalog createCatalog(String name, Map<String, String>
catalogProperties, ClassLoader classLoader) {
+ final CatalogFactory factory =
+ TableFactoryService.find(CatalogFactory.class,
catalogProperties, classLoader);
Review comment:
Shall we rename the factory service, coz we are here creating catalogs
rather than tables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
