Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1115#issuecomment-139276623
Thank, Greg, for this contribution, this is a good idea.
I think we need to extend it a bit. We observed that the object reuse mode
does not work with all types, especially certain user-defined types that are
serialized with Kryo. This is due to problems with empty instantiations and
object-to-object copies. For that reason, we made the non-reusing mode the
default, and the reusing mode optional.
All parts were one could not configure reuse/non-reuse were realized with
non-reuse, to be on the safe side.
To keep this safe, I would like to use by default the non-reusing mode and
the reusing mode when object reuse has been activated. For that, the reuse flag
would have to be passed to the `UnilateralSortMerger`, and interpreted in the
intermediate merge (line 1588ff).
If you could add this, it would be perfect and on the safe side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
