sunjincheng121 commented on a change in pull request #8561:
[FLINK-12588][python] Add TableSchema for Python Table API.
URL: https://github.com/apache/flink/pull/8561#discussion_r288808037
##########
File path: flink-python/pyflink/table/table_descriptor.py
##########
@@ -177,6 +177,10 @@ def __init__(self):
self._j_schema = gateway.jvm.Schema()
super(Schema, self).__init__(self._j_schema)
+ def schema(self, table_schema):
+ self._j_schema = self._j_schema.schema(table_schema._j_table_schema)
Review comment:
Add the Python Doc Align with JAVA? such as:
```
Sets the schema with field names and the types. Required.
This method overwrites existing fields added with ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
